refactor: version implementation #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
reviewed
Jun 22, 2023
| @@ -7,7 +7,7 @@ use std::path::{Path, PathBuf}; | |||
| #[derive(Debug, Clone)] | |||
| pub struct PythonInfo { | |||
| /// The major and minor version | |||
| pub short_version: (usize, usize), | |||
| pub short_version: (u64, u64), | |||
There was a problem hiding this comment.
I want to live to see Python 18446744073709551615 :D
There was a problem hiding this comment.
Haha yeah, it's what's stored in a Version because you can have: 202306221907 (year month day hour minute) which is bigger than the largest u32.
wolfv
reviewed
Jun 22, 2023
wolfv
reviewed
Jun 22, 2023
| } | ||
|
|
||
| /// Returns the index of the first segment that belongs to the local version or `None` if there | ||
| /// is not local version |
wolfv
reviewed
Jun 22, 2023
| Version::from_str("1.2l").unwrap() | ||
| ) | ||
| } | ||
| // #[test] |
There was a problem hiding this comment.
Are we ready to re-enable this test? Or do we not need that function anymore?
There was a problem hiding this comment.
Btw. in rattler-build we have some functions like pin_compatible(otherpkg, min_pin="x.x", max_pin="x.x") which would resolve to >=1.4,<1.5, so being able to "bump" versions is nice.
wolfv
approved these changes
Jun 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a complete refactor of the version implementation. The primary goal was to reduce the memory footprint because versions are used in RepoData quite a lot. The secondary goal was to simplify the implementation, I think I achieved this by returning an iterator of the version segments vs accessing multiple arrays to get to the data. The implementation of the
flagmakes it a bit more complex though. If based on a review this is the case I have some ideas.Just like the previous implementation, this implementation tries to keep most memory on the stack unless the version requires more memory. Most versions are in the form of
1.2.3so we can take advantage of that. The new implementation takes136128 bytes of stack memory per Version. The old one was 440. Changes in heap allocations remain the same. More research is needed to figure out how to further reduce this.I will follow up this PR with another one that refactors the parsing to make it more robust.
Ideally, I also wanted to add some benchmarking but didn't get the time to. Perhaps that's for later!
Oh yeah, this implementation also fixes #255. With the new implementation, it was much simpler to implement dropping a segment for comparison without allocation.
Fix #225