Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sha256 and md5 field in matchspec #241

Merged
merged 8 commits into from
Jul 2, 2023
Merged

Add support for sha256 and md5 field in matchspec #241

merged 8 commits into from
Jul 2, 2023

Conversation

0xbe7a
Copy link
Contributor

@0xbe7a 0xbe7a commented Jul 2, 2023

Closes #207

Currently, MatchSpec and NamelessMatchSpec share a considerable amount of logic and fields, with the former essentially being the latter plus a name field.

A future PR should look into merging these two classes to reduce redundancy, streamline the codebase and improve maintainability.

@0xbe7a 0xbe7a changed the title Add matching based on hashes Add support for sha256 and md5 field in matchspec Jul 2, 2023
baszalmstra
baszalmstra requested changes Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

I agree that we should merge the two representations. I'm already working on a PR that refactors both types, reduces the memory footprint, and increases performance! 👍

crates/rattler_conda_types/src/match_spec/mod.rs Outdated Show resolved Hide resolved
crates/rattler_conda_types/src/match_spec/mod.rs Outdated Show resolved Hide resolved
crates/rattler_conda_types/src/match_spec/mod.rs Outdated Show resolved Hide resolved
crates/rattler_conda_types/src/match_spec/mod.rs Show resolved Hide resolved
@0xbe7a 0xbe7a requested a review from baszalmstra July 2, 2023 14:32
baszalmstra
baszalmstra reviewed Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small comments otherwise looks good to me!

crates/rattler_conda_types/src/match_spec/mod.rs Outdated Show resolved Hide resolved
crates/rattler_conda_types/src/match_spec/mod.rs Outdated Show resolved Hide resolved
@baszalmstra baszalmstra merged commit f3eddf0 into conda:main Jul 2, 2023
@baszalmstra
Copy link
Collaborator

@0xbe7a thanks a lot!!

@0xbe7a 0xbe7a deleted the hash-specs branch July 2, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for sha256 and md5 field in matchspec
2 participants
@0xbe7a @baszalmstra