Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove apple-codesign crate #259

Merged
merged 7 commits into from
Jul 13, 2023
Merged

remove apple-codesign crate #259

merged 7 commits into from
Jul 13, 2023

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Jul 12, 2023

No description provided.

@baszalmstra baszalmstra changed the title update all dependencies to see if the CI error goes away remove apple-codesign crate Jul 13, 2023
@baszalmstra
Copy link
Collaborator

@pavelzw So in the end we still ended up removing the apple-codesign binary.

  • The build was utterly failing on the crate.
  • The maintainer doesn't seem very open to fixing our issue.
  • Cross-creating environments for Mac with ad-hoc certificates will still not work on another mac (defeating its purpose completely)

We ended up using the codesign binary on Mac.

The upside is that maybe now the other targets you were trying will work?

@pavelzw
Copy link
Contributor

pavelzw commented Jul 13, 2023 •
edited
Loading

So ppc64le still has hope 🤪 I'll get right to it once this is merged 😎

CC @0xbe7a

@wolfv wolfv merged commit 7ee16d8 into conda:main Jul 13, 2023
@wolfv wolfv deleted the fix_dependencies branch July 13, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfv @baszalmstra @pavelzw