Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add initial nushell support #271

Merged
merged 3 commits into from
Sep 28, 2023
Merged

add initial nushell support #271

merged 3 commits into from
Sep 28, 2023

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Jul 23, 2023

No description provided.

@baszalmstra
Copy link
Collaborator

@wolfv I know you were still working on this. Is this now ready for review?

@baszalmstra
Copy link
Collaborator

bump @wolfv

@wolfv
Copy link
Contributor Author

wolfv commented Sep 26, 2023

I think it's ready for review, but I haven't had a chance to actually test this yet :)

@wolfv
Copy link
Contributor Author

wolfv commented Sep 27, 2023

I've just tested this a bit with pixi & nushell (and fixed a bug with let-env vs. $env.).

There is an issue with nushell not executing the source command in the PTY right away but I think we might have to fix in pixi.

@baszalmstra baszalmstra merged commit d61936e into conda:main Sep 28, 2023
8 checks passed
@baszalmstra baszalmstra mentioned this pull request Oct 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfv @baszalmstra