Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/remove override method #317

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

baszalmstra
Copy link
Collaborator

Removes the override_package method to make sure that data added to the pool is immutable. This ensures that we can cache things based on id because the data pointed to by the id will never change.

The SolvableMetadata was kind of a hack to add certain associations.
This was only used to lookup the original package record associated with
a solvable. However, since the refactor this information is directly
stored in the solvable so we can just extract the information from the
pool directly. This simplifies the code and removes the need for
additional bookkeeping.
@baszalmstra baszalmstra requested a review from tdejager September 7, 2023 10:15
@wolfv wolfv merged commit 0e02731 into conda:main Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants