Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fetch repo data to py-rattler #334

Merged
merged 24 commits into from
Sep 26, 2023
Merged

add fetch repo data to py-rattler #334

merged 24 commits into from
Sep 26, 2023

Conversation

Wackyator
Copy link
Contributor

@Wackyator Wackyator commented Sep 12, 2023 •
edited
Loading

This adds fetch_repo_data to py-rattler.
NOTE: This introduces an API change fetch_repo_data in rattler_repodata_gateway.
TODO:

  • Lots of tests
  • Fix the breaking changes caused in rattler

baszalmstra
baszalmstra reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you couldve split this PR in multiple smaller ones.

I have a few comments with regards to the design (subclass RepoDataRecord from PackageRecord, missing sparse index) but nothing that we cant do later!

If you add some tests this looks good to me!

@Wackyator
Copy link
Contributor Author

I agree this should have been split into smaller PRs, would have been easier to debug and faster to merge, let me fix the CI issues and add tests

baszalmstra
baszalmstra reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add license information to the test-server and we are good to go!

@Wackyator
Copy link
Contributor Author

done, let's go

baszalmstra
baszalmstra approved these changes Sep 26, 2023
View reviewed changes
test-data/test-server/README.md Outdated Show resolved Hide resolved
@baszalmstra baszalmstra merged commit c6f1e3f into conda:main Sep 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wackyator @baszalmstra