feat: add strict channel priority option #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Oct 21, 2023
Comment on lines
143
to
149
| if strict_channel_priority { | ||
| if let Some(url) = found_in_channel.clone() { | ||
| if repo_data.channel.base_url != url { | ||
| continue; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This can be done much shorter:
Suggested change
| if strict_channel_priority { | |
| if let Some(url) = found_in_channel.clone() { | |
| if repo_data.channel.base_url != url { | |
| continue; | |
| } | |
| } | |
| } | |
| if found_in_channel.map_or(false, |c| c != &repo_data.channel.base_url) { | |
| continue; | |
| } |
You dont need to check the strict_channel_priority because the found_in_channel is only set if that is true.
There was a problem hiding this comment.
That is much better!
Comment on lines
176
to
178
| if strict_channel_priority && !records.is_empty() { | ||
| found_in_channel = Some(repo_data.channel.base_url.clone()); | ||
| } |
There was a problem hiding this comment.
Just store a reference to forgo a clone:
Suggested change
| if strict_channel_priority && !records.is_empty() { | |
| found_in_channel = Some(repo_data.channel.base_url.clone()); | |
| } | |
| if strict_channel_priority && !records.is_empty() { | |
| found_in_channel = Some(&repo_data.channel.base_url); | |
| } |
baszalmstra
reviewed
Oct 21, 2023
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
This was referenced Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips options for a package in other channels if it is already found in channels that are defined first.