Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make the channel in the matchspec struct an actual channel #401

Merged

Conversation

ruben-arts
Copy link
Collaborator

This should really help make installation more correct.

I got the issue that conda-forge::python and conda::python got the same result after installation.
So I changed the type of the channel to be a channel from the start.

WDYT?

Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you turn it into an Arc this looks good to me!

@ruben-arts
Copy link
Collaborator Author

If you turn it into an Arc this looks good to me!

Done, please check if that is correct.

@baszalmstra baszalmstra merged commit f839abd into conda:main Nov 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants