-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consistent clobbering & removal of __pycache__
#437
Conversation
cc @Wackyator we could also re-use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like the simplicity!
looks awesome, will add this to the bindings :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot @wolfv ! Lets get it merged asap!
e207ae9
to
e1de44a
Compare
OK, now I just need to write some tests for the unlinking parts and then I think we're done with this one :) ... the easiest would be to resolve some actual packages, install, then unlink them. But I don't think we have a test harness for that yet. |
@baszalmstra when you get around to review this, please make sure to really carefully review the |
@baszalmstra I took care of your comments. Two things we might still want to do:
|
__pycache__
issues__pycache__
This attempts to fix two issues:
__pycache__
folders fornoarch
packages (otherwise the package is still "detected" in thesite-packages
folder).However, there is still two remaining issues with clobbering:
crates2.json
would becomecrates2.json-clobber-from-mypackage
. For unclobbering we could just rename the file.