Add read_package_file function
#472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
force-pushed
the
extract-package-file
branch
from
4761941 to
51e4441
Compare
baszalmstra
approved these changes
Jan 9, 2024
baszalmstra
reviewed
Jan 9, 2024
| @@ -45,7 +45,8 @@ impl SimpleChannelServer { | |||
|
|
|||
| // Spawn the server. Let go of the JoinHandle, we can use the graceful shutdown trigger to | |||
| // stop the server. | |||
| let _ = tokio::spawn(server); | |||
| let future = tokio::spawn(server); | |||
There was a problem hiding this comment.
I think this should just be _future instead of dropping.
There was a problem hiding this comment.
clippy was suggesting this.
There was a problem hiding this comment.
Yeah its a bug. Assignment to _ immediately drops the value. Which might be counterintuitive. But we do want to keep the value around (I think).
But whatever, the tests still succeed so nvm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function allows us to extract a single
PackageFilefrom a given archive.