add timeout parameter and SolverOptions to return early #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichmor
approved these changes
Jan 29, 2024
| @@ -378,6 +388,15 @@ impl<'a> DependencyProvider<SolverMatchSpec<'a>> for CondaDependencyProvider<'a> | |||
|
|
|||
| Dependencies::Known(dependencies) | |||
| } | |||
|
|
|||
| fn should_cancel_with_value(&self) -> Option<Box<dyn std::any::Any>> { | |||
There was a problem hiding this comment.
sorry for being slow - why the return type is not Option<Box<dyn CancelReason>> but dyn Any?
There was a problem hiding this comment.
It's defined like that in the trait (in resolvo) so I think we need to honor that contract and return an Box<Any>
baszalmstra
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be very useful for the bots and also for
rattler-server.