fix: remove drop-bomb, move empty folder removal to post_process
#519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
force-pushed
the
post-process-empty-folders
branch
from
80f811d to
046d34b
Compare
wolfv
force-pushed
the
post-process-empty-folders
branch
from
046d34b to
ee0a61e
Compare
baszalmstra
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed a race condition when removing empty folders - during the execution of a transaction it can happen that one package gets unlinked and cleans up empty folders after itself, while another one is already installing new files into the folders. This is a race condition due to the way we parellely link all the files.
In order to fix this issue this PR moves the cleaning out of empty folders until after we're done unlinking and linking new files into the prefix and then does a (synchronous) cleaning of all empty folders in the prefix (that are not explicitly mentioned as empty directories).