fix: allow multiple clobbers per package #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
force-pushed
the
fix-clobber-multiple-file
branch
from
3eab914 to
a68e07e
Compare
wolfv
changed the title
baszalmstra
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where we were writing the new prefix records too early. That made the clobbering resolution only work for the first clobbered file.
Before, other files are resolved and renamed properly, but this was not stored in the
PrefixRecord. Subsequent operations were thus failing.This modifies the
PrefixRecordin memory and only writes the new data at the end of theunclobberingoperation.