Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "timeout" parameter or other stop conditions #8

Closed
wolfv opened this issue Nov 7, 2023 · 1 comment · Fixed by #20
Closed

Add a "timeout" parameter or other stop conditions #8

wolfv opened this issue Nov 7, 2023 · 1 comment · Fixed by #20

Comments

@wolfv
Copy link
Member

wolfv commented Nov 7, 2023

One thing that would be nice is to be able to configure "stop" conditions for the solver.

E.g. to be able to say:

  • if you don't find a solution after 5 seconds, give up and return a TimeoutError
  • if you have looped 300k times, stop and return a MaxIterationError

That's something we could never do with libsolv, so would be nice to have!
@Eh2406
Copy link

Eh2406 commented Nov 7, 2023

In pubgrub-rs we added a should_cancel to our DependencyProvider Trait, so that the user could configure their own timeout mechanism. If resolvo comes up with something better I would be happy to copy it in pubgrub-rs.

@wolfv wolfv mentioned this issue Jan 24, 2024
Closed
@aochagavia aochagavia mentioned this issue Jan 25, 2024
Merged
@wolfv wolfv closed this as completed in #20 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow cancelling the solving process aochagavia/resolvo
2 participants
@wolfv @Eh2406