Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOTICEs are not echoed with echo-message enabled. #80

Open
progval opened this issue Dec 24, 2015 · 3 comments
Open

NOTICEs are not echoed with echo-message enabled. #80

progval opened this issue Dec 24, 2015 · 3 comments

Comments

@progval
Copy link
Contributor

progval commented Dec 24, 2015

No description provided.

@Mikaela
Copy link
Contributor

Mikaela commented Dec 25, 2015

I assume this is because of RFC 1459 section 4.4.2 notice

The difference between NOTICE and PRIVMSG is that automatic replies must never be sent in response to a NOTICE message. This rule applies to servers too - they must not send any error reply back to the client on receipt of a notice.

@DanielOaks
Copy link
Member

I think this is just a bug. The relevant section in the spec says: If enabled, servers MUST send PRIVMSG and NOTICE messages back to the client that sent them.

@kaniini
Copy link
Contributor

kaniini commented Dec 27, 2015

m_NOTICE and m_PRIVMSG have different behaviour, it may be worth changing this up a little

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DanielOaks @progval @Mikaela @kaniini and others