-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More consistent and safe use of exceptions in do_remove()
#518
Labels
enhancement
New feature or request
Comments
A similar issue exists in Currently, the function returns |
poodlewars
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Dec 19, 2023
poodlewars
added
enhancement
New feature or request
and removed
bug
Something isn't working
labels
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An extension of #447
Currently,
do_remove_impl
in S3 (andMongoStorage::do_remove
) swallows all errors in the batching loop and reports the keys in the erroring requests in aKeyNotFoundException
at the end.This has multiple issues:
THROTTLING
orSLOW_DOWN
, we should sleep. Otherwise, a subsequent request that might otherwise work will failKeyNotFoundException
is very misleadingFor example, the second issue can fool the
StorageLock::unlock()
logic into believing the lock key has been removed, leading to a race condition or deadlock.I think it's more reliable to:
KeyNotFoundException
at the endIn the latter case, it's the caller's responsibility to retry immediately or leave the data in a sound state for the user to retry.
The text was updated successfully, but these errors were encountered: