Bugfix/1518/get description date range incorrect after delete data in range #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdealtry
approved these changes
Apr 24, 2024
willdealtry
reviewed
Apr 24, 2024
| details::visit_type(start_index_column.type().data_type(), [&start_index_column, &start_index](auto column_desc_tag) { | ||
| using type_info = ScalarTypeInfo<decltype(column_desc_tag)>; | ||
| if constexpr (is_time_type(type_info::data_type)) { | ||
| start_index = start_index_column.template scalar_at<timestamp>(0); |
There was a problem hiding this comment.
Was there a reason not to use start_value_for_segment and end_value_for_segment from index.hpp?
There was a problem hiding this comment.
This is an index key, not a data key
alexowens90
deleted the
bugfix/1518/get-description-date-range-incorrect-after-delete-data-in-range
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1518