Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable metrics option for sidecar process #39

Open
helmerm opened this issue Jan 30, 2022 · 2 comments
Open

Enable metrics option for sidecar process #39

helmerm opened this issue Jan 30, 2022 · 2 comments
Assignees
Milestone

Comments

@helmerm
Copy link

helmerm commented Jan 30, 2022

Describe the feature

Support to disable the metrics server of the sidecar process.

Example command
daprd --app-id test --enable-metrics=false

The DaprSentryProcess and DaprPlacementProcess both support this parameter.

Release Note

RELEASE NOTE:

ADD Support for --enable-metrics parameter for sidecar process

@badgeratu
Copy link
Contributor

I'm struggling to remember why we didn't do this originally, I suspect the option wasn't available on the daprd process in the early days but I can see it is now. You're welcome to submit a PR to resolve it, if not we'll get to it with the next round of changes. In the meantime can you outline the problem having metrics enabled is causing you?

@helmerm
Copy link
Author

helmerm commented Feb 2, 2022

If I find the time to create a PR before you guys, I let you know.

We are running multiple dapr sidecars on the same windows machine. Sidekick automatically tries to find a free port if the default is blocked. However, our python process' sidecar does not, which caused port conflicts and prevented the sidecar from starting.
At the moment we do not use the metrics, that's why I wanted to turn it off.

For our situation, it was enough to turn it off for the python process, but I also wanted to do this for .NET.

@badgeratu badgeratu self-assigned this May 30, 2023
@badgeratu badgeratu added this to the 1.3.0 milestone May 30, 2023
@badgeratu badgeratu modified the milestones: 1.3.0, 2.0.0 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants