Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach mode health check throws exception if daprd exits #7

Closed
a-elsheikh opened this issue Jun 8, 2021 · 0 comments · Fixed by #15
Closed

Attach mode health check throws exception if daprd exits #7

a-elsheikh opened this issue Jun 8, 2021 · 0 comments · Fixed by #15
Assignees
Labels
bug Something isn't working
Milestone

Comments

@a-elsheikh
Copy link
Contributor

a-elsheikh commented Jun 8, 2021

Expected Behavior

When running sidekick in attach mode, if the daprd process goes down then the dapr process health check should report unhealthy

Actual Behavior

The dapr process health is throwing an exception if the daprd process is unavailable during attach mode. The sidekick is under the impression that the process is still running and attempts a http request which fails

Steps to Reproduce the Problem

  1. run daprd with an app-id and app-port
  2. start a sidekick service with a matching app-id and app-port
  3. wait for service to attach and report healthy
  4. kill the daprd process
  5. observe HttpRequestException in logs

Release Note

TBD

@badgeratu badgeratu added the bug Something isn't working label Jul 23, 2021
@badgeratu badgeratu added this to the v1.1 milestone Jul 23, 2021
@badgeratu badgeratu self-assigned this Jul 28, 2021
@badgeratu badgeratu linked a pull request Jul 28, 2021 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants