Skip to content

Package to Docker then publish to Docker Hub? #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiminhsieh opened this issue Feb 5, 2018 · 12 comments
Closed

Package to Docker then publish to Docker Hub? #3

jiminhsieh opened this issue Feb 5, 2018 · 12 comments

Comments

@jiminhsieh
Copy link

I think it's a good idea since not all of the people use Java 9 locally. And if anyone needs it, he or she can just pull the image.

@manasb-uoe
Copy link
Owner

That's a great idea! Will try to get this done by end of week. Thanks for the suggestion.

@labedzkim
Copy link

Hi! Did you already put it onto hub? What's the repo/image name? Best regards, Maciej.

@manasb-uoe
Copy link
Owner

manasb-uoe commented Feb 27, 2018

@labedzkim Nah, have been really busy in the last few weeks. I do definitely plan to do this though. In the meantime, if you want to continue using java 8, you can revert the following commit in your fork:

eaa6d1a

Cheers

@dupf
Copy link

dupf commented Mar 6, 2018

what is the default port of the project

Repository owner deleted a comment from dupf Mar 6, 2018
@jiminhsieh
Copy link
Author

@labedzkim If you don't mind, I can help this one with Travis CI.

@labedzkim
Copy link

Sure, go on.

@code-sauce
Copy link

any updates on this?

@jiminhsieh
Copy link
Author

I am quite busy recently. If anyone wants to take over, please go ahead.

@karan1525
Copy link
Contributor

Hey,
I went ahead and created a dockerfile for this Kafka-visualizer.
You can access it here -> https://github.com/karan1525/Kafka-Visualizer/blob/master/Dockerfile

It is also pushed to the docker hub under -> kbhargava/kafka-visuals

Hope this helps!

@manasb-uoe
Copy link
Owner

@karan1525 Thanks for that! Could you also please submit a PR to include the docker file to this project?

@karan1525
Copy link
Contributor

@enthusiast94 Created a PR :)

@manasb-uoe
Copy link
Owner

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants