F/process spawn #984
F/process spawn #984
Conversation
|
You might also want to look into https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user |
technorama
force-pushed
the
f/process_spawn
branch
from
b77c214
to
91d60d2
Compare
Add error checking to some fcntl calls.
Refactor Process#run to use Process#spawn.
technorama
force-pushed
the
f/process_spawn
branch
5 times, most recently
from
7275dce
to
125a498
Compare
Refactor Process#run code simplified now accepts stderr as an argument Add Process::Status#close closes any pipes to the child and waits for the process to exit Add minimal documentation and additional specs
technorama
force-pushed
the
f/process_spawn
branch
from
125a498
to
3617e44
Compare
|
@technorama "We" finally implemented this in bbf2036 I say "we" because we used your code a lot. We were very happy to find out you did exactly what we had in mind. The only small issue we had is that we didn't want to have more than one way to execute a process ( I briefly documented the methods, I guess we would need to add more docs and examples showing many usages, because the API is very flexible. We also didn't include the Thank you so much for working on this!! Once we saw your implementation and think/combined it with what we had in mind, doing it was a breeze! We also hope you like the simplification we made :-) |
Add Process#spawn (almost identical to ruby version with some features not yet implemented).
Add some documentation.
Better error checking in a few places and less chance to leak file descriptors.