Skip to content

Commit 2f172ee

Browse files
manavgupclaude
andcommitted
fix(workflow): Add SKIP_AUTH default value to prevent Pydantic validation errors
This PR fixes Pydantic validation errors that were occurring when the SKIP_AUTH secret was empty. ## Problem When SKIP_AUTH secret is not set or empty, the backend receives an empty string '', causing: ``` Input should be a valid boolean, unable to interpret input [type=bool_parsing, input_value='', input_type=str] ``` This was causing backend deployments to fail during the Code Engine application startup. ## Solution Added default value 'false' to SKIP_AUTH environment variable: **Before**: ```yaml SKIP_AUTH: ${{ secrets.SKIP_AUTH }} ``` **After**: ```yaml SKIP_AUTH: ${{ secrets.SKIP_AUTH || 'false' }} ``` Now when the secret is empty, the backend receives 'false' instead of '', which Pydantic can parse as a boolean. ## Testing This fix will be validated in the next deployment workflow run. Expected behavior: - If SKIP_AUTH secret is set: uses that value - If SKIP_AUTH secret is empty/unset: defaults to 'false' - Backend starts successfully without Pydantic validation errors ## Related - Part of deployment fixes series (breaking down PR #641) - Related to PR #642 (backend Docker fixes) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 3e92d10 commit 2f172ee

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/deploy_complete_app.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,9 @@ env:
8585
IBM_CLOUD_REGION: ${{ vars.IBM_CLOUD_REGION || 'us-south' }}
8686
CR_NAMESPACE: ${{ vars.IBM_CR_NAMESPACE || 'rag_modulo' }}
8787
# ICR uses shortened region names: us-south -> us, eu-gb -> uk, ca-tor -> ca, etc.
88-
ICR_REGION: ${{ vars.IBM_CLOUD_REGION == 'eu-gb' && 'uk' || (vars.IBM_CLOUD_REGION == 'us-south' && 'us' || (vars.IBM_CLOUD_REGION == 'us-east' && 'us' || (vars.IBM_CLOUD_REGION == 'ca-tor' && 'ca' || vars.IBM_CLOUD_REGION))) }}
88+
ICR_REGION: ${{ vars.IBM_CLOUD_REGION == 'eu-gb' && 'uk' || (vars.IBM_CLOUD_REGION == 'us-south' && 'us' ||
89+
(vars.IBM_CLOUD_REGION == 'us-east' && 'us' || (vars.IBM_CLOUD_REGION == 'ca-tor' && 'ca' ||
90+
vars.IBM_CLOUD_REGION))) }}
8991

9092
# Prevent concurrent deployments to avoid conflicts
9193
concurrency:
@@ -341,7 +343,7 @@ jobs:
341343
APP_NAME: ${{ env.BACKEND_APP_NAME }}
342344
IBM_CLOUD_REGION: ${{ env.IBM_CLOUD_REGION }}
343345
IBM_CLOUD_RESOURCE_GROUP: ${{ vars.IBM_CLOUD_RESOURCE_GROUP || 'rag-modulo-deployment' }}
344-
SKIP_AUTH: ${{ secrets.SKIP_AUTH }}
346+
SKIP_AUTH: ${{ secrets.SKIP_AUTH || 'false' }}
345347
OIDC_DISCOVERY_ENDPOINT: ${{ secrets.OIDC_DISCOVERY_ENDPOINT }}
346348
IBM_CLIENT_ID: ${{ secrets.IBM_CLIENT_ID }}
347349
IBM_CLIENT_SECRET: ${{ secrets.IBM_CLIENT_SECRET }}

0 commit comments

Comments
 (0)