fix(infra): Address final PR review items

1. Fix MinIO credential validation
   - Explicitly check for empty strings in addition to nil checks
   - Improved error messages to clarify non-empty requirement
   - Ensures validation catches empty string values

2. Remove .terraform.lock.hcl files
   - Removed 3 .terraform.lock.hcl files from git tracking
   - Added .terraform.lock.hcl to .gitignore
   - These files are provider-specific and should not be committed

3. Verify Chart.yaml exists
   - Confirmed Chart.yaml is present and properly configured
   - Chart metadata is correct (version 0.8.0, proper description)

All review items from PR #679 have been addressed.

Author: manavgup

.gitignore

@@ -130,6 +130,7 @@ tfplan
 *.tfvars
 !*.tfvars.example
 *.auto.tfvars
+.terraform.lock.hcl
 
 # Helm
 deployment/helm/*/charts/

deployment/helm/rag-modulo/templates/minio-statefulset.yaml

@@ -1,10 +1,10 @@
 {{- if .Values.minio.enabled }}
 {{- if not .Values.minio.auth.existingSecret }}
-{{- if not .Values.minio.auth.rootUser }}
-{{- fail "MinIO rootUser must be provided via .Values.minio.auth.rootUser or .Values.minio.auth.existingSecret must be set" }}
+{{- if or (not .Values.minio.auth.rootUser) (eq .Values.minio.auth.rootUser "") }}
+{{- fail "MinIO rootUser must be provided via .Values.minio.auth.rootUser (non-empty) or .Values.minio.auth.existingSecret must be set" }}
 {{- end }}
-{{- if not .Values.minio.auth.rootPassword }}
-{{- fail "MinIO rootPassword must be provided via .Values.minio.auth.rootPassword or .Values.minio.auth.existingSecret must be set" }}
+{{- if or (not .Values.minio.auth.rootPassword) (eq .Values.minio.auth.rootPassword "") }}
+{{- fail "MinIO rootPassword must be provided via .Values.minio.auth.rootPassword (non-empty) or .Values.minio.auth.existingSecret must be set" }}
 {{- end }}
 ---
 # MinIO Secret (credentials)