Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change error codes to positive numbers #1269

Closed
mr-tz opened this issue Jan 9, 2023 · 1 comment · Fixed by #1274
Closed

Change error codes to positive numbers #1269

mr-tz opened this issue Jan 9, 2023 · 1 comment · Fixed by #1274
Assignees
@mr-tz
Labels
breaking-change introduces a breaking change that should be released in a major version
Milestone
5.0.0

Comments

@mr-tz
Copy link
Collaborator

mr-tz commented Jan 9, 2023

We currently use negative numbers. I propose to change these to adhere to the more standard positive error code, e.g., value between 1 and 127 or 1 and 255.

capa/capa/main.py

Lines 76 to 85 in 93acf9f

E_MISSING_RULES = -10
E_MISSING_FILE = -11
E_INVALID_RULE = -12
E_CORRUPT_FILE = -13
E_FILE_LIMITATION = -14
E_INVALID_SIG = -15
E_INVALID_FILE_TYPE = -16
E_INVALID_FILE_ARCH = -17
E_INVALID_FILE_OS = -18
E_UNSUPPORTED_IDA_VERSION = -19

@mr-tz mr-tz added the breaking-change introduces a breaking change that should be released in a major version label Jan 9, 2023
@mr-tz mr-tz added this to the 5.0.0 milestone Jan 9, 2023
@williballenthin
Copy link
Collaborator

sound good to me

@mr-tz mr-tz self-assigned this Jan 9, 2023
@mr-tz mr-tz mentioned this issue Jan 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mr-tz mr-tz

Labels
breaking-change introduces a breaking change that should be released in a major version
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

use positive error return code numbers mandiant/capa
2 participants
@williballenthin @mr-tz