-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit test after Binary Ninja 3.5 release #1789
Comments
Oh, this might not be that bad. We have deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have released Binary Ninja 3.5 last Friday. I thought we simply need to update the binja version check here: https://github.com/mandiant/capa/blob/master/tests/test_binja_features.py#L72, since it explicitly checks for version 3.4.
However, as it seems, the failures is more deadly than expected: it seems BN 3.5 crashes during the unit test: https://github.com/mandiant/capa/actions/runs/6235434766/job/16924696404#step:7:70. I will have a look at what have changed and see how it can be fixed
The text was updated successfully, but these errors were encountered: