Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect print for tqdm #749

Closed
mr-tz opened this issue Aug 30, 2021 · 3 comments · Fixed by #1488
Closed

redirect print for tqdm #749

mr-tz opened this issue Aug 30, 2021 · 3 comments · Fixed by #1488
Labels
CI Continuous Integration configuration

Comments

@mr-tz
Copy link
Collaborator

mr-tz commented Aug 30, 2021

see redirecting_print_to_tqdm in lint.py

Originally posted by @mr-tz in #747 (comment)
@mr-tz mr-tz added the CI Continuous Integration configuration label Aug 30, 2021
@williballenthin williballenthin mentioned this issue Dec 6, 2021
Merged
3 tasks
@Aayush-Goel-04
Copy link
Contributor

@mr-tz
In capa main redirect_print_to_tqdm should be added here -
https://github.com/mandiant/capa/blob/e605dfb483ff56b0f60c0177ed148445e4a9dfd9/capa/main.py#LL254C1-L265C17

Should I import redirect_print_to_tqdm here from scripts/lint or create a new function here.

@mr-tz
Copy link
Collaborator Author

mr-tz commented May 12, 2023

I'd say we move it to capa\helpers.py or similar.

@Aayush-Goel-04
Copy link
Contributor

I'd say we move it to capa\helpers.py or similar.

Will start working on it.

  • Create redirect function in capa\helpers.py.
  • Make changes to capa main

This was referenced May 13, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration configuration
Projects
None yet
Milestone
No milestone
2 participants
@mr-tz @Aayush-Goel-04