Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract the union of features from multiple extractors #938

Open
williballenthin opened this issue Apr 4, 2022 · 2 comments
Open

extract the union of features from multiple extractors #938

williballenthin opened this issue Apr 4, 2022 · 2 comments
Labels
breaking-change introduces a breaking change that should be released in a major version question Further information is requested

Comments

@williballenthin
Copy link
Collaborator

when multiple extractors, e.g. native PE and dotnet, can extract features from a binary, e.g. a mixed-mode dotnet program, should we extract the union of features from both extractors? or consider the features separately?

@williballenthin williballenthin added the question Further information is requested label Apr 4, 2022
@williballenthin
Copy link
Collaborator Author

the union seems intuitive and is my intuitive preference, but needs further thought and/or discussion

@mr-tz
Copy link
Collaborator

mr-tz commented Apr 6, 2022

introduced in #955 multiple file-level extractors can run on the same file

the full-feature extraction is not yet implemented that way and will require either

  • harder:
    • more refactoring
    • ways to merge metadata, capabilities, etc. by each extractor
  • easier:
    • modifying the results document to contain multiple results
    • display multiple results tables on the CLI

so far this would only apply to mixed-mode assemblies, which are rather rare

@williballenthin williballenthin added this to the 5.0.0 milestone Jun 28, 2022
@williballenthin williballenthin added the breaking-change introduces a breaking change that should be released in a major version label Jun 28, 2022
@mr-tz mr-tz modified the milestones: 5.0.0, 6.0.0 Dec 21, 2022
@williballenthin williballenthin removed this from the 6.0.0 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change introduces a breaking change that should be released in a major version question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants