Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a dedicated Address representation #981

Closed
williballenthin opened this issue Apr 7, 2022 · 1 comment · Fixed by #986
Closed

introduce a dedicated Address representation #981

williballenthin opened this issue Apr 7, 2022 · 1 comment · Fixed by #986
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@williballenthin
Copy link
Collaborator

various formats represent addresses in different ways, e.g. native code uses VA while .NET uses tokens.

introduce a class hierarchy for addresses that implement the necessary operations (eq, ord, hash, repr). use these instances for "as long as possible" only at the last moment (in render) turning them into textual representations.

this may require some changes to freeze

@williballenthin williballenthin added the enhancement New feature or request label Apr 7, 2022
@williballenthin williballenthin added this to the 4.0.0 milestone Apr 7, 2022
@williballenthin williballenthin self-assigned this Apr 7, 2022
@williballenthin
Copy link
Collaborator Author

optimization: may be able to cache Address instances to be yielded by the extractors to reduce GC pressure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant