Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setupIdTokenTimer() does not with rxjs 7 #1258

Closed
mahmut-gundogdu opened this issue Sep 26, 2022 · 0 comments · Fixed by #1259
Closed

setupIdTokenTimer() does not with rxjs 7 #1258

mahmut-gundogdu opened this issue Sep 26, 2022 · 0 comments · Fixed by #1259
Labels
bug For tagging faulty or unexpected behavior. investigation-needed Indication that the maintainer or involved community members may need to investigate more.

Comments

@mahmut-gundogdu
Copy link
Contributor

mahmut-gundogdu commented Sep 26, 2022

SetupIdTokenTimer function uses delay() operator. It works well with rxjs 6. But when you update your project angular 14 and rxjs 7 also your expire time is greater than 24.6 days. The Delay operator works immediately

setupIdTokenTimer

Describe the bug
Rxjs 6. has custom implementation (without interval or timer), but RXJS 7 uses interval/timer. It has a max value.
https://developer.mozilla.org/en-US/docs/Web/API/setTimeout#maximum_delay_value

Stackblitz example
[Provide a minimal stackblitz based example that shows the issue. For this, you can use the example application of this repo and the identity providers used here.](https://stackblitz.com/edit/angular-ivy-jv2xa4?file=src/app/app.component.ts)

To Reproduce
Steps to reproduce the behavior:

  1. Update your examplerxjs 7
  2. set a value that greater than expire time 2.147.483.647

Expected behavior
The token operation refresh will be started, over and over.

@jeroenheijmans jeroenheijmans added bug For tagging faulty or unexpected behavior. investigation-needed Indication that the maintainer or involved community members may need to investigate more. labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For tagging faulty or unexpected behavior. investigation-needed Indication that the maintainer or involved community members may need to investigate more.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants