Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use history api to remove token from url #622

Open
manfredsteyer opened this issue Sep 10, 2019 · 3 comments
Open

use history api to remove token from url #622

manfredsteyer opened this issue Sep 10, 2019 · 3 comments
Labels
feature-request Improvements and additions to the library.

Comments

@manfredsteyer
Copy link
Owner

Describe the bug
Currently, the lib uses location.hash to remote the received token from the url. However, this is triggering the Angular router and can lead to race conditions with other routing requests.

To Reproduce
Steps to reproduce the behavior:

  1. Use official example
  2. Use router.navigate on token_received event
  3. You get an race condition with the router

Expected behavior
router.navigate should work

Further notes
We should add an example that shows how to reroute the user to the originally requested url after login.

@jeroenheijmans
Copy link
Collaborator

This would chop off IE9 support (which is on the list for Angular itself but not the history API it seems).

(I'm personally fine with that - don't even know if IE9 works currently. Just a heads up.)

@jeroenheijmans jeroenheijmans added the feature-request Improvements and additions to the library. label Sep 12, 2019
@vadjs
Copy link
Contributor

vadjs commented Sep 12, 2019

Angular team planing to drop IE support (including IE 11) in next year. So, if IE 9 support will be dropped with this feature, i think it will be good.

@manfredsteyer
Copy link
Owner Author

Ah, good point @jeroenheijmans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Improvements and additions to the library.
Projects
None yet
Development

No branches or pull requests

3 participants