Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Authorization Code Flow work with loadDiscoveryDocumentAndLogin(); #661

Closed
thxmike opened this issue Nov 4, 2019 · 4 comments
Closed
Labels
bug For tagging faulty or unexpected behavior.

Comments

@thxmike
Copy link

thxmike commented Nov 4, 2019

Describe the bug
I recently had a requirement to move over to using Authorization Code Flow.
So I used the documentation located here
https://manfredsteyer.github.io/angular-oauth2-oidc/docs/additional-documentation/code-flow-+-pcke.html
However, I do not have an explicit login button, so I have the user automatically redirected to the identity login screen. So I use this.oauthService.loadDiscoveryDocumentAndLogin(); instead of this.oauthService.loadDiscoveryDocumentAndTryLogin(); This works great for implicit flow. However, it appears, when I make the change to the responseType, it does not appear to be using the correct flow when it calls this.oauthService.loadDiscoveryDocumentAndLogin(). I see the call for this.initImplicitFlow();
Any suggestions on how to get this to work with Authorization Code Flow without an explicit button for logging in?

@calleufuzi
Copy link

I have a same issue, do anyone have a idea?

@manfredsteyer manfredsteyer added the bug For tagging faulty or unexpected behavior. label Nov 5, 2019
@manfredsteyer
Copy link
Owner

Thanks for this pointer and this great analysis of the issue.

I'll make this a priority for the next version which will land very soon.

@emanuelegaleotti-quix
Copy link

Do you have a release date? or at least an idea of when the change will take place?
I am inserting the pkce into a new product and I am in trouble right now

@mike-rivera
Copy link
Contributor

Created a fork which addresses this issue.
https://github.com/mike-rivera/angular-oauth2-oidc?organization=mike-rivera&organization=mike-rivera
and a PR into the base
#720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For tagging faulty or unexpected behavior.
Projects
None yet
Development

No branches or pull requests

5 participants