Debug mode with custom Logger breaks

[jonyeezs]

Describe the bug
When having config showDebugInformation set as true and using a custom logger implementing OAuthLogger.
It throws an error where

console is undefined

To Reproduce
Steps to reproduce the behavior:

1. Implement a OAuthLogger base on its contract.
2. Have its injected service that is called internally

   export class CustomLogger {
      constructor() {
           this.thirdParty = {
                execute: (a) => console.log('[3rd]', a);
          }
      }
   
     debug(...args) {
          this.thirdParty.execute(args);
     }
   }

3. Add to that to the moudule

    { provide: OAuthLogger, useClass: CustomLogger }

4. Have showDebugInformation enabled

 showDebugInformation: true,

5. Run the app

Expected behavior
Should see the logs go through my custom thirdParty object.

Additional context
The problem i see is that it applies this to console, which i do not want.
I would expect it to just use the debug method and let the abstraction implement what it should do with the input.

[jonyeezs]

I could turn the injector into a factory. But that's not really a good option for a nice UX DI experience as it is not following the contract API

[jeroenheijmans]

Hmm, I originally wrote the OAuthLogger type, with typings compatible with console because I was at the time just trying to replace console.log calls with an abstracted version.

Currently, the default is already provided through a factory, and you should be able to use a same approach with your own custom logger, non?

I suppose that could be changed so that the typings are more friendly to classes like your own with a ...args setup, though I do expect that changing the OAuthLogger typing would be a breaking change....

Does this provide you with enough info to fix something in your app, or do you still propose a specific change to the lib?

[jonyeezs]

Hi, thanks for the reply. Unfortunately, the factory pattern isn't the solution nor the problem. The logger interface is perfect. It is with the `apply` method that is change the `this` context. I have lost my private objects to `this` now being `console`. I don't think we need to use `console` as the `this` as the default factory already wraps that up. Proposed solution(s): ```js this.logger.debug(...args) //or this.logger.debug.apply(this.logger, args) //or this.logger.debug(args[0], args.slice(1)) ```

[jeroenheijmans]

Makes sense to me.

If someone cares to create a PR to update this that would be nice. (Fair warning though: PRs typically wait quite a bit of time before getting merged, usually only when a new Angular major version lands.)

[manfredsteyer]

Will work in version 9. lands soon.