Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Download novels as webpages instead of image format #6504

Open
Tracked by #40
xeolod opened this issue Dec 5, 2023 · 10 comments
Open
Tracked by #40

[Feature] Download novels as webpages instead of image format #6504

xeolod opened this issue Dec 5, 2023 · 10 comments
Labels
Enhancement Improvement or Feature

Comments

@xeolod
Copy link

xeolod commented Dec 5, 2023

Is your feature request related to a problem? Please describe.

  • Currently hakuneko downloads any novel chapters as an image format.
  • The novel chapters when zoomed in looks ugly (cause its an image and not a web page).
  • And the reading experience is awful. If doesn't feel right. But when the chapter is read from xhtml the reading experience is good.

Describe the solution you'd like

  • I would like it to download the novel chapters as xhtml instead of image format.

Describe alternatives you've considered

  • None

Context (please complete the following information):

  • Your current HakuNeko Version [rev. master@d1163e]

Additional context

@xeolod xeolod added the Enhancement Improvement or Feature label Dec 5, 2023
@xeolod xeolod changed the title [Feature] novels as webpages instead of image format [Feature] Download novels as webpages instead of image format Dec 5, 2023
@MikeZeDev
Copy link
Contributor

Already asked wont append in Hakuneko Maybe in Haruneko

@MikeZeDev MikeZeDev closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
@xeolod
Copy link
Author

xeolod commented Dec 5, 2023

I did not find this source one in hakuneko issue, so is this a mistake?

@zeoint
Copy link

zeoint commented Dec 6, 2023

Not a mistake, see #6280, #242 in haruneko and #40 in haruneko.

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Dec 6, 2023

You linked everything so i dont have to explain much.

  • No need for duplicate issues so i closed this one
  • Planned in Haruneko
  • Wont add a complex feature like this in Hakuneko, no time. Unless a contributor does that maybe.

If my english isnt clear enough i am sorry, i am not a native speaker.

@Sheepux
Copy link
Contributor

Sheepux commented Dec 8, 2023

Reopening to crosstrack in haru as I'm unsure if this feature will be done in haru before it gets merged into haku.
Note to MrRabbit: We let feature requests in haku's repo if we are not sure we'll do it before we delete haru's repo (once it's mature and merged to haku's. Too much requests in haru's repo would be a nightmare.

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Dec 8, 2023

I see, my bad then :)
Ill close this one then ? #2987

@MikeZeDev
Copy link
Contributor

This rises many questions like how to make sure the layout is ok. Do we fetch the novel HTML and just save it as HTML? Not the whole page and we are tasked to remove stuff ? Or we may miss the CSS styles of the document, not talking about external CSS? What about the preview? If we let the preview as image how can we distinguish the Preview mode and the Downloading mode? Should we remove all scripts by default in fetched html? Since it will be saved as html script can be nasty.

@zeoint
Copy link

zeoint commented Dec 12, 2023

I suggest checking out webtoepub for reference.

Do we fetch the novel HTML and just save it as HTML?

  • Maybe saving it as xhtml would be better as it would be stricter.

Or we may miss the CSS styles of the document, not talking about external CSS?

  • I think CSS are not necessary.
  • I never saw any novel (like the one in the below video) use any CSS rules that matters.
  • CSS file of 3000+ chapters novel, after cleaning the CSS rules not used in the novel using calibre - CSS for entire novel.txt

What about the preview?

  • Download the preview chapter as xhtml (temporary OS directory) and displaying it would solve it?

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Dec 12, 2023

Download the preview chapter as xhtml (temporary OS directory) and displaying it would solve it?

I mean we display a picture made of the text right now.

  • A picture is harmless.
  • If the interface is made to display pictures if will require a rework to display html instead

@zeoint
Copy link

zeoint commented Dec 12, 2023

A picture is harmless.

Then picture it is for preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement or Feature
Projects
None yet
Development

No branches or pull requests

4 participants