Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto discussion #157

Open
MikeZeDev opened this issue Jun 12, 2023 · 4 comments
Open

Crypto discussion #157

MikeZeDev opened this issue Jun 12, 2023 · 4 comments
Labels
Engine META Meta issues : Discussions , notes

Comments

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Jun 12, 2023

There was a talk about getting rid of CryptoJS dependency used in Hakuneko for Haruneko.

First here is a summary of website/connectors witch CryptoJS references, and some words about uses and replacement with SubtleCrypto :

  • Batoto : use in injected script, so we dont care✔️

  • Cerisescan : use in injected script, so we dont care , ✔️

  • Comikfuz : use AES. " formatter: CryptoJS.format.OpenSSL" doesnt change anything apparently. ✔️

  • CocoManhua : see Mangadig ✔️

  • Comico : use SHA256 and AES . Successfully recoded with Subtle ✔️

  • Comikey : ❓

  • GManga : use AES and SHA256. Recoded using Subtle .TEMPLATE ✔️

  • HeroScan: use in injected script, so we dont care (and site is dead), ✔️

  • Mangadig : use AES. ✔️

  • MangaFox : use SHA256 to check for ad picture. No problem at all i think. TEMPLATE ✔️

  • MangaHere : see MangaFox ✔️

  • MangaPark (and derivated) : use in injected script, so we dont care✔️

  • MangaSY : use in injected script, so we dont care✔️

  • MangaTales : check GMANGA ✔️

  • MangaZ : use AES. Successfully recoded with Subtle ✔️

  • ManhuaScan : use in injected script, so we dont care✔️

  • PixivComics : removed MD5 uses, now uses SHA256, should be ok ✔️

  • SinensisScan : use in injected script, so we dont care✔️

  • VRV : uses HMAC signing. SubtleCrypto support HMAC iirc . TEMPLATE ❓

  • we use the encoding stuff of CryptoJS to encode Page parameter, but its now useless in Haruneko (?).✔️

  • Settings are crypted using AES using CryptoJS since there are sensitive data (websites login and passwords) ✔️

@MikeZeDev
Copy link
Contributor Author

@MikeZeDev
Copy link
Contributor Author

Pixiv dropped MD5. <3

@MikeZeDev MikeZeDev added the META Meta issues : Discussions , notes label Oct 12, 2023
@MikeZeDev
Copy link
Contributor Author

Comic FUZ works without problems #332

@MikeZeDev
Copy link
Contributor Author

Coco/Mangadig done using subtle 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engine META Meta issues : Discussions , notes
Projects
None yet
Development

No branches or pull requests

1 participant