Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev problem : "load" event not triggered because of ads #165

Open
MikeZeDev opened this issue Jun 27, 2023 · 2 comments
Open

Dev problem : "load" event not triggered because of ads #165

MikeZeDev opened this issue Jun 27, 2023 · 2 comments
Labels
Bug Something isn't working Enhancement New feature or request

Comments

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Jun 27, 2023

I got the case today on Hakuneko for ReadComicOnline.

Let me be clear : Its a Hakuneko issue that i believe can happen in Haruneko.

I needed to execute a script on the page (fetchui). The page could have a captcha so i put a 60seconds timeout.
The webpage NEVER close. Because you have to click on an ad for the load event to be send and Hakuneko to close the page.

  • If there was a captcha before, window is visible to the user but he still need to click on the ad
  • if no captcha was present we end up being timeouted after 60 seconds because windows is invisible so user cant click .
  • Blacklisting ads host allow the load event to be fired and fetchui to work properly. But ads hosts are changing and random letters and numbers, blacklisting all is not viable.

Possible solution : Allow a way to execute JavaScript after an arbitrary delay (ignoring the load event) and gracefully "close" the browser window even if load event is not triggered, when the promise is fulfilled maybe?

@MikeZeDev MikeZeDev added Bug Something isn't working Enhancement New feature or request Engine and removed Bug Something isn't working Engine labels Jul 25, 2023
@ronny1982
Copy link
Contributor

ronny1982 commented Dec 2, 2023

If you are referring to popup dialogs blocking the window from being closed, this is already handled by PreventDialogs

@MikeZeDev
Copy link
Contributor Author

No its something like, overlay ads perhaps? Its weird to define. Its just that the load event never fires and each time i encounter that page got some annoying ads. When i blacklist the hosts, the problem vanishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants