-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzzy search option #35
Comments
Should https://github.com/krisk/Fuse be an affordable option for us? |
@Robonau take a look at the PR video to get an idea of the implementation. |
I truly wonder how it behaves on non ASCII languages |
Fuse doesn't support searching through non-ASCII characters. Explained in this issues. |
I'm mostly thinking on asian characters as they are quite a big part of the connectors. |
Could you kindly provide a way to test this out? Hopefully something could be done under this issue for that @Sheepux . |
@sisco0 you can find example data with asian characters in this manga list. More examples available at https://github.com/manga-download/hakuneko-cdn |
Actually i can't. That's something to be "defined". Or probably there should be some kind of (automatic?) function to disable the fuzzy search (can be done in another PR).
Well need someone asian to let us know about issues around false positiv, to tell us about the quality of this feature on their languages. |
After testing the
For sure, having a user who could test in-depth the filter feature for non-ASCII characters would be great. |
So the feature seems quite good. |
I'll close it for now. Fuzzy seems ok |
cause of the multiple titles translations problem
so currently HN will not get
Tensei Kizoku no Isekai Boukenroku - Jichou wo Shiranai Kamigami no Shito
if the site is
Tensei Kizoku no Isekai Boukenroku - Jichou o Shiranai Kamigami no Shito
the only differance is the missing
w
but its a pretty common differancefuzzy would deal with this quite handily
english example:
She Professed Herself Pupil of the Wiseman
She Professed Herself the Pupil of the Wise Man
and exact matches would still be at the top of the list, so its not gonna make it any worse
The text was updated successfully, but these errors were encountered: