Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzy search option #35

Closed
Robonau opened this issue Nov 29, 2021 · 11 comments
Closed

fuzzy search option #35

Robonau opened this issue Nov 29, 2021 · 11 comments
Labels
enhancement New feature or request UI Classic Related to svelte issues

Comments

@Robonau
Copy link

Robonau commented Nov 29, 2021

cause of the multiple titles translations problem

so currently HN will not get
Tensei Kizoku no Isekai Boukenroku - Jichou wo Shiranai Kamigami no Shito
if the site is
Tensei Kizoku no Isekai Boukenroku - Jichou o Shiranai Kamigami no Shito
the only differance is the missing w but its a pretty common differance
fuzzy would deal with this quite handily
english example:
She Professed Herself Pupil of the Wiseman
She Professed Herself the Pupil of the Wise Man
and exact matches would still be at the top of the list, so its not gonna make it any worse

@Sheepux Sheepux added the enhancement New feature or request label Nov 29, 2021
@Sheepux Sheepux changed the title [enhancement] fuzzy search option fuzzy search option Nov 29, 2021
@Sheepux Sheepux added the UI Classic Related to svelte issues label Nov 29, 2021
@ronny1982 ronny1982 assigned ronny1982 and unassigned ronny1982 Jan 16, 2022
@sisco0
Copy link
Contributor

sisco0 commented Jan 24, 2022

Should https://github.com/krisk/Fuse be an affordable option for us?

@sisco0
Copy link
Contributor

sisco0 commented Jan 24, 2022

@Robonau take a look at the PR video to get an idea of the implementation.

@Sheepux
Copy link
Contributor

Sheepux commented Jan 24, 2022

I truly wonder how it behaves on non ASCII languages

@manh21
Copy link

manh21 commented Jan 25, 2022

I truly wonder how it behaves on non ASCII languages

Fuse doesn't support searching through non-ASCII characters. Explained in this issues.
The known workaround is to convert non ASCII to ASCII using diacritics

@Sheepux
Copy link
Contributor

Sheepux commented Jan 25, 2022

I'm mostly thinking on asian characters as they are quite a big part of the connectors.

@sisco0
Copy link
Contributor

sisco0 commented Jan 25, 2022

Could you kindly provide a way to test this out? Hopefully something could be done under this issue for that @Sheepux .

@manh21
Copy link

manh21 commented Jan 26, 2022

@sisco0 you can find example data with asian characters in this manga list. More examples available at https://github.com/manga-download/hakuneko-cdn

@Sheepux
Copy link
Contributor

Sheepux commented Jan 26, 2022

Could you kindly provide a way to test this out? Hopefully something could be done under this issue for that @Sheepux .

Actually i can't. That's something to be "defined". Or probably there should be some kind of (automatic?) function to disable the fuzzy search (can be done in another PR).
You can find special chars in the sheep's manga unit-test connector

@sisco0 you can find example data with asian characters in this [manga list]

Well need someone asian to let us know about issues around false positiv, to tell us about the quality of this feature on their languages.

@sisco0
Copy link
Contributor

sisco0 commented Jan 30, 2022

After testing the Sheep's Awesome Mangas connector, I have two conclusions made up:

  1. It seems that the search is working correctly when the exactly same symbols are taken as input, even with missing symbols in-between. Evidence is attached at the end of this message.
  2. The Real 23 example images are very funny, this was a really great surprise to find.

For sure, having a user who could test in-depth the filter feature for non-ASCII characters would be great.

image

@Sheepux
Copy link
Contributor

Sheepux commented Feb 16, 2022

So the feature seems quite good.
So what is left ? Chapter search ? Connector search ?
Do we need regexp search as we have multiple chapter selection available.

@Sheepux
Copy link
Contributor

Sheepux commented May 7, 2022

I'll close it for now. Fuzzy seems ok

@Sheepux Sheepux closed this as completed May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI Classic Related to svelte issues
Projects
None yet
Development

No branches or pull requests

5 participants