Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review search_references() #85

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Review search_references() #85

merged 2 commits into from
Sep 2, 2019

Conversation

KevCaz
Copy link
Member

@KevCaz KevCaz commented Sep 2, 2019

  • review search_references() so that it behaves just as the other search_*() funs
  • add a new test 🛡️
  • untrack website (i.e. the content of docs/) 🔥

@KevCaz KevCaz added enhancement New feature or request rOpenSci - review Adress reviewers comments labels Sep 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #85 into master will increase coverage by 0.07%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   91.79%   91.86%   +0.07%     
==========================================
  Files          12       12              
  Lines         329      332       +3     
==========================================
+ Hits          302      305       +3     
  Misses         27       27
Impacted Files Coverage Δ
R/search_references.R 100% <100%> (ø) ⬆️
R/get_collection.R 100% <100%> (ø) ⬆️
R/search_networks.R 95.65% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368d120...549ae17. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Sep 2, 2019

Codecov Report

Merging #85 into master will increase coverage by 0.07%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   91.79%   91.86%   +0.07%     
==========================================
  Files          12       12              
  Lines         329      332       +3     
==========================================
+ Hits          302      305       +3     
  Misses         27       27
Impacted Files Coverage Δ
R/search_references.R 100% <100%> (ø) ⬆️
R/get_collection.R 100% <100%> (ø) ⬆️
R/search_networks.R 95.65% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368d120...549ae17. Read the comment docs.

@SteveViss SteveViss merged commit 8b4dc92 into master Sep 2, 2019
@KevCaz
Copy link
Member Author

KevCaz commented Sep 4, 2019

@SteveViss SteveViss deleted the search_ref branch March 28, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rOpenSci - review Adress reviewers comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants