Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open apps button opens ALL sparkle apps #26

Closed
Wdavery opened this issue Aug 16, 2018 · 6 comments
Closed

Open apps button opens ALL sparkle apps #26

Wdavery opened this issue Aug 16, 2018 · 6 comments
Assignees
Labels
Milestone

Comments

@Wdavery
Copy link

Wdavery commented Aug 16, 2018

The button in the top right corner that used to open all apps with updates, now opens all apps that are using sparkle.
Although it was quite the show, and I was pleasantly surprised at how well my computer handled opening 54 apps simultaneously, I definitely won't be clicking that again.

@Wdavery Wdavery changed the title Open apps button opens all sparkle apps Open apps button opens ALL sparkle apps Aug 16, 2018
@mangerlahn
Copy link
Owner

Wow, I am super sorry for that!

@mangerlahn mangerlahn self-assigned this Aug 16, 2018
@mangerlahn mangerlahn added the bug label Aug 16, 2018
@mangerlahn mangerlahn modified the milestones: 0.4.1, Version 0.4 Aug 16, 2018
@Wdavery
Copy link
Author

Wdavery commented Aug 16, 2018

Haha, hopefully I caught it before other people run into it too.

As an aside, I think the icon for that function may not be super clear.
To me it looks like a "grid mode" option for sorting.

It might be better to change to a text option of "Update All".
Update All

@mangerlahn
Copy link
Owner

Yeah, thank you so much for reporting fast! I just uploaded a new binary that fixes this particular problem, as it could crash peoples machines..

#27 will be fixed tomorrow in 0.4.1. I just want to make sure I did not mess up anything else 🤪

I don't like the icon either. To move that into the table view seems like a good idea, I just have to see where I put that if the sections are not visible.
Long term, I just want to update the apps right from Latest, instead of opening them. I just have to see how to manage that..

@mangerlahn
Copy link
Owner

If you have time, feel free to download the new version to verify that this is fixed. You can close this issue then.

@Wdavery Wdavery closed this as completed Aug 16, 2018
@mangerlahn
Copy link
Owner

mangerlahn commented Aug 16, 2018

Ha, made you click that button again 😅

No seriously, thanks!

@Wdavery
Copy link
Author

Wdavery commented Aug 16, 2018

Not going to lie, I was a bit nervous. Love the quick fix though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants