Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capLevelToStage on retina displays #443

Closed
MixMasterMitch opened this issue Nov 18, 2015 · 2 comments
Closed

capLevelToStage on retina displays #443

MixMasterMitch opened this issue Nov 18, 2015 · 2 comments

Comments

@MixMasterMitch
Copy link
Contributor

When I set capLevelToStage to true, the capping is based on the reported size of the window, but not the actual resolution of the window. In particular, if I have a 480p video window on a non-retina display it will be properly capped at level 4, but then if I move the window to a retina display, the window will still report as being 480p and stay at level 4, but in reality the window will be 960 pixels tall (480x2) and should be at level 8. In other words, flashls appears to be capping using the Device Independent Pixel Size (dips), not the actual pixel size.

Would it be possible to have the capping logic use the actual pixel size instead of the dips?

More info:
https://developer.mozilla.org/en-US/docs/Web/API/Window/devicePixelRatio
http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/display/Stage.html#contentsScaleFactor

@mangui
Copy link
Owner

mangui commented Nov 18, 2015

that would make sense indeed, i will look into it.

@mangui
Copy link
Owner

mangui commented Nov 20, 2015

merged, thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants