Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If buffer < 0.1 HLSNetstream not paused if in PLAYING_BUFFERING #511

Closed
shanekerr opened this issue Apr 12, 2016 · 3 comments
Closed

If buffer < 0.1 HLSNetstream not paused if in PLAYING_BUFFERING #511

shanekerr opened this issue Apr 12, 2016 · 3 comments

Comments

@shanekerr
Copy link

In _checkBuffer on the HLSNetStream the stream is only paused in the event of an empty buffer if the playback state is PLAYING, however in previous buffer checks we will switch to a state of PLAYING_BUFFERING if buffer < _bufferThresholdController.lowBufferLength.

When we have a low bandwidth situation we can find that the netstream is not paused, and so the stream will playback minute bits of buffer as they come in. This can be seen in the chromeless example player by throttling your connection to a very slow speed.

@mangui
Copy link
Owner

mangui commented May 12, 2016

Hi @shanekerr if you can have any fix, a PR would be welcomed

@shanekerr
Copy link
Author

Hi @mangui, I have added a PR of the fix I am using as requested.

@jlacivita
Copy link
Contributor

FYI, I ran into this, too. It's only comes up with bad network conditions or inconsistent live variants (one variant is behind another, so "now" isn't available causing starvation)

I did a local fix that was just a one liner, and seemed to fix it, but wasn't sure it was the right solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants