-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnonsis Safe Support #12
Comments
Yes please 🙏 😄 This would be very appreciated for us at Art Blocks but I think is also aligned with general opsec best practices in terms of protocol-managed/team-managed contracts that are owned by a multi-sig rather than a single end-user-account. |
I support this. The code is open source, so... I'm happy to merge in whatever code is added to make this possible. In the meantime, I guess, maybe some instructions on how to do it manually would help? I would think ppl using Gnosis for contract interactions in general would have some technical competance? |
The code is around here, where we currently just use window.ethereum: royalty-registry-client/src/App.vue Line 54 in aaf22c4
|
Supporting Gnosis Safe wallets on the frontend would be very helpful.
Generally, it is best-practice for the owner/admin of a given contract to be using a multi-sig wallet, such as Gnosis Safe. Thus, a common use-case when assigning overrides for a contract would be to connect to the Royalty Registry frontend with a Gnosis Safe.
An additional driver: The fact that the registry uses a proxy pattern makes it quite difficult for anyone non-technical to properly configure their override via contract calls directly. Knowledge of which contract to integrate with, and which ABI to use is critical when not using the frontend.
Cc @jakerockland
The text was updated successfully, but these errors were encountered: