New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper length validation #38

Open

kdr1 opened this issue Dec 5, 2018 · 1 comment

kdr1 commented Dec 5, 2018

According to RFC-2821, page 54 the character limits are as follows:
path: 256
local-part: 64
domain: 255

I propose the following changes:

index.js
line 13: if(email.length>256)
line 26: if(domainParts.some(function(part) { return part.length>255; }))

The element separator (@) is included in the total length of the path

Owner

manishsaraan commented Dec 24, 2018

Thanks for suggestion @kdr1 . will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment