Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New npm version release for latest code on github #79

Open
anupamSharma94 opened this issue Sep 4, 2023 · 3 comments
Open

New npm version release for latest code on github #79

anupamSharma94 opened this issue Sep 4, 2023 · 3 comments

Comments

@anupamSharma94
Copy link

anupamSharma94 commented Sep 4, 2023

Hi @manishsaraan,

We are using your npm module - email-validator for basic email validations in our NodeJs based application (https://www.npmjs.com/package/email-validator).

We observed that the module was last published 5 years ago with the version 2.0.4. However there are no tags or releases present in the git repo.

npm version 2.0.4 points to the Git commit - https://github.com/manishsaraan/email-validator/blob/2c16df5e6f79b34ccae1baeb62efaee218eb73ac/index.js

We are getting the following issue in the 2.0.4 version release - the email domain length check allows only 254 characters. But as per some global standards for email, the domain length can be of 255 characters.

We checked the git repository and found that some fixes have been made (for the domain length check) after the last npm publish.

PR where the issue was fixed - #53

Our application works fine with the latest master branch commit (df02ecd).

Can you please review and advise if a new npm version can be released, so that our application can fetch the latest code from npm.

Thanks,
Anupam

@houd1ni
Copy link
Collaborator

houd1ni commented Sep 20, 2023

@manishsaraan would be excellent if I could manage this.

@malikzype
Copy link

Can we merge the PR and rollout a new update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@houd1ni @anupamSharma94 @malikzype and others