-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify the dimension of the flags #44
Comments
@jabbalaci Yes, definitely. Seriously, there is a need to first fix this. Thank you for opening this issue. Would you like to suggest some guidelines? |
@jabbalaci Agreed. Also, perhaps the correct flag proportions should be enforced. I believe most are defined and shown on Wikipedia. |
@module17 Apart from proportions, we should give a set canvas beyond which person cannot go. Or should we just give exact dimensions? Are there any online tools to check this? |
@manrajgrover Absolutely. Perhaps we can set a maximum width. The proportions will vary, but we can limit the "display width" of the div representation as well as any included assets. Hmm, but then again some flags with such a small maximum width wouldn't be able to show the finer details adequately. 600 pixels? |
Also, @jabbalaci I agree that whitespace guidelines should exist as well. I don't see a reason for any whitespace or margins personally. |
I think some pixels can be allowed for the margins, but not much more. It could be difficult to crop the flag perfectly, but some pixel rows and columns around the flag are acceptable IMO. |
@jabbalaci If we use SVG and generate PNG from fixed SVG export size we can be consistent. Maybe? |
A good and fast solution to this looks to be mentioned here. I'll try it out soon or would love a PR for fixing this. 😄 |
This has now been fixed. 😄 Closing this. |
Currently the flag screenshots are all different. There should be a guideline about 1) the size of these images, and 2) the size of the margins around the flags.
The text was updated successfully, but these errors were encountered: