Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid setting incorrect values for numeric fields #2312

Open
5 tasks
Nick-S-2018 opened this issue Jun 17, 2024 · 5 comments
Open
5 tasks

Forbid setting incorrect values for numeric fields #2312

Nick-S-2018 opened this issue Jun 17, 2024 · 5 comments
Assignees

Comments

@Nick-S-2018
Copy link
Collaborator

Nick-S-2018 commented Jun 17, 2024

Bug Description:

Now we convert incorrect values of numeric data types ( e.g., "a" or "" for the bigint field) , to 0. Instead, we should forbid such conversion and throw an appropriate error.
But if a value can be correctly converted to number (e.g. "123") , conversion still must be done.

Alternatively, we could introduce some kind of option enabling/disabling such strict conversion which the user would be able to use to get more flexible behavior

Manticore Search Version:

Manticore 6.3.1 9bd02672d@24061008 dev

Operating System Version:

Ununtu 22.04 LTS

Have you tried the latest development version?

Yes

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
@Nick-S-2018
Copy link
Collaborator Author

@sanikolaev
Copy link
Collaborator

@Nick-S-2018 pls improve the spec, e.g.:

  • should string->numeric conversion still happen for ID?
  • what about cases like "123"?

@Nick-S-2018
Copy link
Collaborator Author

I've updated the description to cover these details

@sanikolaev
Copy link
Collaborator

@Nick-S-2018 does this issue block anything?

@Nick-S-2018
Copy link
Collaborator Author

No, it's not a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants