Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FindPeaksConvolveTest more reliable #37752

Open
sf1919 opened this issue Aug 6, 2024 · 1 comment · May be fixed by #37970
Open

Make FindPeaksConvolveTest more reliable #37752

sf1919 opened this issue Aug 6, 2024 · 1 comment · May be fixed by #37970
Assignees
@warunawickramasingha
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Diffraction Issues and pull requests related to diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS
Milestone
Release 6.11

Comments

@sf1919
Copy link
Contributor

sf1919 commented Aug 6, 2024

Describe the bug
The FindPeaksConvolveTest is flaky and fails intermittently and has been recorded doing so through the Mantid Failing Unit Test Dashboard for Linux - https://mantidproject.github.io/unittest-monitor/Linux_table.html . It has also failed on Windows (see https://mantidproject.github.io/unittest-monitor/Windows_table.html) but as of 06/08/24 has not failed on MacOS.

To Reproduce
These are some of the stack traces from the failures from Linux

00:07:24  1399/2722 Test  #295: AlgorithmsTest_FindPeaksConvolveTest .........................................................................................................***Failed    5.98 sec
00:07:24  FrameworkManager-[Notice] Welcome to Mantid 6.10.20240723.1433.dev11
00:07:24  FrameworkManager-[Notice] Please cite: http://dx.doi.org/10.1016/j.nima.2014.07.029 and this release: http://dx.doi.org/10.5286/Software/Mantid
00:07:24  Running 13 testsLoadNexusProcessed-[Notice] LoadNexusProcessed started
00:07:24  LoadNexusProcessed-[Notice] LoadNexusProcessed successful, Duration 0.67 seconds
00:07:24  LoadNexusProcessed-[Notice] LoadNexusProcessed started
00:07:24  LoadNexusProcessed-[Notice] LoadNexusProcessed successful, Duration 0.02 seconds
00:07:24  LoadNexusProcessed-[Notice] LoadNexusProcessed started
00:07:24  ISISRunLogs-[Warning] Cannot find status log. Logs will be not be filtered by run status
00:07:24  ISISRunLogs-[Warning] Cannot find period log. Logs will be not be filtered by current period
00:07:24  ISISRunLogs-[Warning] Cannot find periods log. Logs will be not be filtered by current period
00:07:24  LoadNexusProcessed-[Notice] LoadNexusProcessed successful, Duration 0.72 seconds
00:07:24  
00:07:24  21FindPeaksConvolveTest.......FindPeaksConvolve-[Error] Error in execution of algorithm FindPeaksConvolve:
00:07:24  FindPeaksConvolve-[Error] Validation error: Peak Extent has been given in x units and in number of bins. Please specify one or the other. 
00:07:24  .FindPeaksConvolve-[Error] Error in execution of algorithm FindPeaksConvolve:
00:07:24  FindPeaksConvolve-[Error] Validation error: You must specify either peakExtent or peakExtentNBins. 
00:07:24  .FindPeaksConvolve-[Error] Error in execution of algorithm FindPeaksConvolve:
00:07:24  FindPeaksConvolve-[Error] Validation error: If both specified, EndWorkspaceIndex must be greater than StartWorkspaceIndex. 
00:07:24  .FindPeaksConvolve-[Error] Error in execution of algorithm FindPeaksConvolve:
00:07:24  FindPeaksConvolve-[Error] Validation error: Specified Workspace indicies out of range. 
00:07:24  ..Segmentation fault
00:07:24  
00:07:24            Start  295: AlgorithmsTest_FindPeaksConvolveTest

14:58:09  1615/2712 Test  #295: AlgorithmsTest_FindPeaksConvolveTest .........................................................................................................***Failed    3.40 sec
14:58:09  FrameworkManager-[Notice] Welcome to Mantid 6.9.20240617.1426.dev22
14:58:09  FrameworkManager-[Notice] Please cite: http://dx.doi.org/10.1016/j.nima.2014.07.029 and this release: http://dx.doi.org/10.5286/Software/Mantid
14:58:09  Running 13 testsLoadNexusProcessed-[Notice] LoadNexusProcessed started
14:58:09  LoadNexusProcessed-[Notice] LoadNexusProcessed successful, Duration 0.53 seconds
14:58:09  LoadNexusProcessed-[Notice] LoadNexusProcessed started
14:58:09  LoadNexusProcessed-[Notice] LoadNexusProcessed successful, Duration 0.04 seconds
14:58:09  LoadNexusProcessed-[Notice] LoadNexusProcessed started
14:58:09  ISISRunLogs-[Warning] Cannot find status log. Logs will be not be filtered by run status
14:58:09  ISISRunLogs-[Warning] Cannot find period log. Logs will be not be filtered by current period
14:58:09  ISISRunLogs-[Warning] Cannot find periods log. Logs will be not be filtered by current period
14:58:09  LoadNexusProcessed-[Notice] LoadNexusProcessed successful, Duration 0.77 seconds
14:58:09  
14:58:09  21FindPeaksConvolveTest.......FindPeaksConvolve-[Error] Error in execution of algorithm FindPeaksConvolve:
14:58:09  FindPeaksConvolve-[Error] Validation error: Peak Extent has been given in x units and in number of bins. Please specify one or the other. 
14:58:09  .FindPeaksConvolve-[Error] Error in execution of algorithm FindPeaksConvolve:
14:58:09  FindPeaksConvolve-[Error] Validation error: You must specify either peakExtent or peakExtentNBins. 
14:58:09  .FindPeaksConvolve-[Error] Error in execution of algorithm FindPeaksConvolve:
14:58:09  FindPeaksConvolve-[Error] Validation error: If both specified, EndWorkspaceIndex must be greater than StartWorkspaceIndex. 
14:58:09  .FindPeaksConvolve-[Error] Error in execution of algorithm FindPeaksConvolve:
14:58:09  FindPeaksConvolve-[Error] Validation error: Specified Workspace indicies out of range. 
14:58:09  ..Segmentation fault
14:58:09  
14:58:09            Start  295: AlgorithmsTest_FindPeaksConvolveTest

The failure on Windows is no longer available.

Expected behavior
The FindPeaksConvolveTest will not appear as a flaky/unrelaible test on the dashboard anymore.

Screenshots
Failures on Linux (up to 06/08/24)

Screenshot (384)

Failure on Windows (up to 06/08/24)

Screenshot (383)

Platform/Version (please complete the following information):
N/A

Additional context
@sf1919 sf1919 added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Diffraction Issues and pull requests related to diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS labels Aug 6, 2024
@sf1919
Copy link
Contributor Author

sf1919 commented Aug 7, 2024

I don't know if it's worth mentioning that there is a Coverity issue listed for FindPeaksConvolve . It might be that fixing that helps with stability of the test? See below for more info (the last number is the line number where the issue occurs)

1542210 | Use of auto that causes a copy | Low | 03/26/24 | Framework | Performance inefficiencies | /jenkins_workdir/workspace/coverity_build_and_submit/Framework/Algorithms/src/FindPeaksConvolve.cpp | populateOutputWorkspaces | 458

@RichardWaiteSTFC RichardWaiteSTFC added this to the Release 6.11 milestone Aug 13, 2024
@warunawickramasingha warunawickramasingha linked a pull request Sep 12, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warunawickramasingha warunawickramasingha

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Diffraction Issues and pull requests related to diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS
Projects
ISIS Diffraction
Status: In Progress
Milestone
Release 6.11
Development

Successfully merging a pull request may close this issue.

37752 FindPeaksConvolve flaky Test fix mantidproject/mantid
3 participants
@sf1919 @RichardWaiteSTFC @warunawickramasingha