Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add popover to TimeInput #622

Closed
converter-user-old opened this issue Jan 4, 2022 · 7 comments
Closed

Add popover to TimeInput #622

converter-user-old opened this issue Jan 4, 2022 · 7 comments

Comments

@converter-user-old
Copy link
Contributor

converter-user-old commented Jan 4, 2022

Usage example, including component/hook API

Like this (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time):

image

Possible implementation – describe how the feature can be implemented

No response

Do you want to contribute this feature and create a pull request

No response

@UltraInstinct05
Copy link
Contributor

A sliding reel maybe complicated to implement. A dropdown seems easier. As an example https://demos.telerik.com/kendo-ui/timepicker/index

@converter-user-old
Copy link
Contributor Author

I will look at that later but I think we can also add a select (like the normal Input).

@jerebtw
Copy link
Contributor

jerebtw commented Jan 4, 2022

I will wait for #607 to be merged and than work on this 👍🏻

@rtivital
Copy link
Member

rtivital commented Jan 4, 2022

@jerebtw please don't, we will not add this feature, instead we will have a new TimePicker component that allows to pick time similar to Select

@jerebtw
Copy link
Contributor

jerebtw commented Jan 4, 2022

I saw that but is that not a Date and Time picker?

@rtivital
Copy link
Member

rtivital commented Jan 4, 2022

I do not get the question, TimeInput – user inputs time, TimePicker – user picks time from the given list

@jerebtw
Copy link
Contributor

jerebtw commented Jan 4, 2022

My bad I thought of this #239 but that's a other thing

@rtivital rtivital changed the title [Feature Request] Add popover to TimeInput Add popover to TimeInput Feb 7, 2022
@mantinedev mantinedev locked and limited conversation to collaborators Mar 19, 2022
@rtivital rtivital converted this issue into discussion #1052 Mar 19, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants