-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename themes back to .css from .html #241
Comments
Hmm but these are not valid .css files due to being wrapped in rootstock/build/themes/default.html Lines 1 to 4 in ed4158c
Therefore I think just changing the extension would mess up syntax highlighting, linting, and the semantics of inserting this file directly into an HTML document. Would using a name like Also are we sure that we'll never need to put other HTML content other than style in the default theme? |
I think these things can be configured such that the file is just treated like an HTML file. Some linters may even be smart enough to just recognize that it's html automatically. But also, if we're talking about semantics, this file really truly is a CSS file. And I don't think we'll ever need to add anything else but CSS to it. Maybe we can get rid of the surrounding |
Removing the |
Even though the theme files are technically
.html
(well, they're really fragments of a valid.html
file), I think we should rename them back to.css
. For those who know what CSS is, they might be looking around for where to modify the CSS, and would be confused to find it in an HTML file, probably.The text was updated successfully, but these errors were encountered: