SETUP.md repo sed substitution is failing

[dhimmel]

At the OpenCon do-a-thon, we've had 2 users experience potentially faulty substitutions. Rather than rebranding their README to USER/REPO, their README.md is rebranded to USER/USER. Possibly introduced in #84?

The two examples are https://github.com/zambujo/manubot/commit/10397d6a05235c3517ac981b9b3c67920c226b9a are broadwym/manu1@64954e5.

Interestingly one user did not have the issue: https://github.com/schliebs/open_manuscript/commit/77da6c844ac061061c03b93721e7eade90fabd99, making me wonder whether its user error or not.

SETUP.md currently uses:

sed "s/greenelab/$OWNER/g" README.md > tmp && mv -f tmp README.md
sed "s/manubot-rootstock/$REPO/g" README.md > tmp && mv -f tmp README.md

@vsmalladi any ideas what could be happening?

[agitter]

@dhimmel (or @zambujo and @broadwym) what operating system was used on the failed setup?

[vsmalladi]

@dhimmel that is weird, not sure why it would fail since we didn't change the syntax.

[dhimmel]

what operating system was used on the failed setup?

@zambujo was on Linux (had issue), @broadwym was on Windows (had issue), and @schliebs was on Windows (no issue).

not sure why it would fail since we didn't change the syntax

Yeah me too. Therefore I thought user error is most likely. Although I'm surprised that two people had the same issue. Also @zambujo thought that he didn't make an error.

[vsmalladi]

I can try a full test on Mac and see if anything inadvertently changed.

[vsmalladi]

@dhimmel I tested this weekend and everything worked fine setting up.

[dhimmel]

I tested this weekend and everything worked fine setting up.

Cool, I'll close this issue and we'll assume there was user error rather than faulty commands.

One thing I noticed is that the demo users would often retype commands rather than copy and paste, which could be the source of some errors.