Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seoByRouteName is bogging down my app #72

Open
queso opened this issue Sep 15, 2015 · 14 comments
Open

seoByRouteName is bogging down my app #72

queso opened this issue Sep 15, 2015 · 14 comments

Comments

@queso
Copy link

queso commented Sep 15, 2015

I am not using the seoByRouteName for any actual data, is there a way we can make it optional?

I am talking about this line of code: https://github.com/DerMambo/ms-seo/blob/66717dd1f8d08c8cb6faadf7545ae123c6e440e8/seo.coffee#L167.

/cc @SachaG

@queso
Copy link
Author

queso commented Sep 15, 2015

This is having a large impact on crater.io performance

@jeffpatzer
Copy link

+1

@kartikTT
Copy link

+1

I actually get the following error consistently:

Exception from sub seoByRouteName id wcAbrwLvTPY6qMMM9 ReferenceError: check is not defined

Not sure if this is because I'm not using seoByRouteName or something else.

@Deisss
Copy link

Deisss commented Nov 19, 2015

Got the same problem (check undefined) which is kind of blur as check is supposed to be part of Meteor.JS documentation...

@quanglam2807
Copy link

+1

6 similar comments
@jasenkoh
Copy link

+1

@adeshpandey
Copy link

+1

@barratt
Copy link

barratt commented Dec 19, 2015

+1

@yhoiseth
Copy link

+1

@gabrielmedina
Copy link

+1

@hobbyexplorer
Copy link

+1

@hobbyexplorer
Copy link

Try this on your meteor app folks:

meteor add check
meteor add ejson

That worked for me.

@aedanmcgarry
Copy link

+1
Removed this because it was far too inefficient. App CPU was jumping around all the time and hitting 100% sometimes especially under heavy traffic. After I removed this app CPU dropped to a steady 5-10% and hitting a max of 20% consistently. It did also have the highest throughput on my app due to it loading every page with an average of 3,500 page views per day.

@guillim
Copy link

guillim commented Oct 31, 2017

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests